squito commented on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete URL: https://github.com/apache/spark/pull/26365#issuecomment-550425623 I agree with Sean, I'm not really sure what the value is of adding this, and it'll potentially prevent the feature from being used in cases it should be fine. Suppose somebody does create `/proc` on macos, and then turns on these metrics without this change -- how bad is it? It seems like one time you'll try to grab the metrics and it'll fail. It will then log an exception and set `isAvailable = false`. Then it won't ever try to grab those metrics again, so its won't spam those exceptions endlessly. (if somebody has manually created a `/proc` that actually looks like the real `/proc` -- well, they'll get bogus metrics, but that's their problem.)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
