wangyum commented on a change in pull request #26340: [WIP][SPARK-29108][SQL]
Add new module sql/thriftserver with all code and UT
URL: https://github.com/apache/spark/pull/26340#discussion_r343407141
##########
File path: .github/workflows/master.yml
##########
@@ -31,7 +31,7 @@ jobs:
run: |
export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g
-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
export MAVEN_CLI_OPTS="--no-transfer-progress"
- ./build/mvn $MAVEN_CLI_OPTS -DskipTests -Pyarn -Pmesos -Pkubernetes
-Phive -Phive-thriftserver -P${{ matrix.hadoop }} -Phadoop-cloud
-Djava.version=${{ matrix.java }} package
+ ./build/mvn $MAVEN_CLI_OPTS -DskipTests -Pyarn -Pmesos -Pkubernetes
-Phive -Phive-thriftserver -Pspark-thriftserver -P${{ matrix.hadoop }}
-Phadoop-cloud -Djava.version=${{ matrix.java }} package
Review comment:
Please change `mvn package` to `mvn install` because your generated code
will throw `not found: type ClassName...`. I have changed it for upstream:
https://github.com/apache/spark/pull/26414
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
