yaooqinn commented on issue #26399: [SPARK-29757][SQL] Move calendar interval constants together URL: https://github.com/apache/spark/pull/26399#issuecomment-550958813 > Maybe we should use tightest type for constant? Instead of: > > ```java > public static final long NANOS_PER_SECOND = MILLIS_PER_SECOND * NANOS_PER_MILLIS; > ``` > > use _**int**_: > > ```java > public static final int NANOS_PER_SECOND = MILLIS_PER_SECOND * NANOS_PER_MILLIS; > ``` > > This should allow to avoid casting like there https://github.com/apache/spark/pull/26399/files#diff-eba257f41b49f470321579875f054f00R482 Many of these constants are used by `codegen`, we may need an overall check to avoid possible overflows
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
