cloud-fan commented on a change in pull request #26418: [SPARK-29783][SQL]
Support SQL Standard output style for interval type
URL: https://github.com/apache/spark/pull/26418#discussion_r343531257
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -409,6 +409,8 @@ case class Literal (value: Any, dataType: DataType)
extends LeafExpression {
DateTimeUtils.getZoneId(SQLConf.get.sessionLocalTimeZone))
s"TIMESTAMP('${formatter.format(v)}')"
case (v: Array[Byte], BinaryType) =>
s"X'${DatatypeConverter.printHexBinary(v)}'"
+ case (v: CalendarInterval, CalendarIntervalType) if
SQLConf.get.ansiEnabled =>
+ IntervalUtils.toSqlStandardString(v)
Review comment:
This should be something that can be parsed, I think we need to output
something like `INTERVAL'1 year 2 days'`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
