LucaCanali commented on a change in pull request #26320: [SPARK-29654][CORE]
Add configuration to allow disabling registration of static sources to the
metrics system
URL: https://github.com/apache/spark/pull/26320#discussion_r343864845
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -615,9 +615,9 @@ package object config {
.stringConf
.createOptional
- private[spark] val METRICS_REGISTER_STATIC_SOURCES_ENABLED =
- ConfigBuilder("spark.metrics.register.static.sources.enabled")
- .doc("Whether to register static sources with the metrics system")
+ private[spark] val METRICS_STATIC_SOURCES_ENABLED =
+ ConfigBuilder("spark.register.static.sources.enabled")
Review comment:
Indeed, thanks. I will add the UT, I have just pushed the corrected config
parameter name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
