cloud-fan commented on a change in pull request #26419:
[SPARK-29680][SQL][Followup] Replace qualifiedName with multipartIdentifier
URL: https://github.com/apache/spark/pull/26419#discussion_r343959145
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -802,7 +808,7 @@ intervalUnit
;
colPosition
- : FIRST | AFTER qualifiedName
Review comment:
`qualifiedName` can't match `a-b`. I take another look, `qualifiedName` is
still needed in places where `-` is a legal following, e.g. `select a - b`, we
must use `qualifiedName` to match column name.
For function name, we can use `multipartIdentifier`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
