HeartSaVioR commented on a change in pull request #26162: [SPARK-29438][SS] Use
partition ID of StateStoreAwareZipPartitionsRDD for determining partition ID of
state store in stream-stream join
URL: https://github.com/apache/spark/pull/26162#discussion_r343965319
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -206,12 +206,20 @@ case class StreamingSymmetricHashJoinExec(
}
private def processPartitions(
+ leftPartitionId: Int,
leftInputIter: Iterator[InternalRow],
+ rightPartitionId: Int,
rightInputIter: Iterator[InternalRow]): Iterator[InternalRow] = {
if (stateInfo.isEmpty) {
throw new IllegalStateException(s"Cannot execute join as state info was
not specified\n$this")
}
+ if (leftPartitionId != rightPartitionId) {
Review comment:
I imagined some case where two RDDs have different number of partitions so
that's to not restricting the function signature, but for
StateStoreAwareZipPartitionsRDD it shouldn't. I think we can move this check to
`StateStoreAwareZipPartitionsRDD.compute` and reduce parameter. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
