HyukjinKwon commented on a change in pull request #26330:
[WIP][SPARK-29672][PYSPARK] remove py27 support for jenkins tests
URL: https://github.com/apache/spark/pull/26330#discussion_r343982918
##########
File path: dev/sparktestsupport/shellutils.py
##########
@@ -57,7 +55,12 @@ def run_cmd(cmd, return_output=False):
if return_output:
return
subprocess_check_output(cmd).decode(sys.getdefaultencoding())
else:
- return subprocess_check_call(cmd)
+ popen = subprocess.Popen(cmd, stdout=subprocess.PIPE)
+ for stdout_line in popen.stdout:
+ print(stdout_line.decode(sys.getdefaultencoding()), end='')
Review comment:
BTW, it's best to stick to `utf-8` (see
https://github.com/apache/spark/commit/2ec3265ae76fc1e136e44c240c476ce572b679df
for instance)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
