maropu commented on a change in pull request #26420: [SPARK-27986][SQL] Support
ANSI SQL filter predicate for aggregate expression.
URL: https://github.com/apache/spark/pull/26420#discussion_r344144318
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1574,7 +1579,7 @@ class Analyzer(
s"its class is ${other.getClass.getCanonicalName}, which
is not a generator.")
}
}
- case u @ UnresolvedFunction(funcId, children, isDistinct) =>
+ case u @ UnresolvedFunction(funcId, children, isDistinct, filter) =>
Review comment:
Could you throw an analysis exception if `filter` given in non-aggregation
functions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
