viirya commented on a change in pull request #26415: [SPARK-18409][ML] LSH
approxNearestNeighbors should use approxQuantile instead of sort
URL: https://github.com/apache/spark/pull/26415#discussion_r344372744
##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala
##########
@@ -71,6 +72,10 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
/** @group setParam */
def setOutputCol(value: String): this.type = set(outputCol, value)
+ /** @group expertSetParam */
+ @Since("3.0.0")
+ def setRelativeError(value: Double): this.type = set(relativeError, value)
Review comment:
I agree with @srowen. Seems this relative error does not mean too much for
users in LSH. If they want more or less NN, they can change numNearestNeighbors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
