Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4334#discussion_r24186435
  
    --- Diff: core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala ---
    @@ -32,10 +32,8 @@ import org.apache.spark.api.java.StorageLevels
     import org.apache.spark.shuffle.FetchFailedException
     
     /**
    - * Selenium tests for the Spark Web UI.  These tests are not run by default
    - * because they're slow.
    + * Selenium tests for the Spark Web UI.
      */
    -@DoNotDiscover
     class UISeleniumSuite extends FunSuite with WebBrowser with Matchers {
       implicit val webDriver: WebDriver = new HtmlUnitDriver
    --- End diff --
    
    We need to call `quit()` on this WebDriver in order to avoid leaking 
resources.  I'll change this to use `BeforeAndAfterAll`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to