beliefer commented on issue #26420: [SPARK-27986][SQL] Support ANSI SQL filter predicate for aggregate expression. URL: https://github.com/apache/spark/pull/26420#issuecomment-552097803 @maropu You said： `I just looked over the current implementation though, I have one question; have you checked that we couldn't just transform this filter exprs into the Spark existing exprs/operators instead of the current approach (hard-coded in each Agg operators)?` I don't understand very well. Do you mean that you should convert a filter expression to part of an aggregate expression or part of an aggregate function?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
