iRakson commented on a change in pull request #26315: [SPARK-29152] Executor
Plugin shutdown when dynamic allocation is ena…
URL: https://github.com/apache/spark/pull/26315#discussion_r344452774
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -294,13 +300,16 @@ private[spark] class Executor(
threadPool.shutdown()
// Notify plugins that executor is shutting down so they can terminate
cleanly
- Utils.withContextClassLoader(replClassLoader) {
- executorPlugins.foreach { plugin =>
- try {
- plugin.shutdown()
- } catch {
- case e: Exception =>
- logWarning("Plugin " + plugin.getClass().getCanonicalName() + "
shutdown failed", e)
+ if (!executorShutdown) {
Review comment:
@srowen I moved the check variable to the beginning of the method. Please
review the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
