srowen commented on a change in pull request #26455: [SPARK-29819][SQL]
Introduce an enum for interval units
URL: https://github.com/apache/spark/pull/26455#discussion_r344462181
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -28,6 +28,22 @@ import org.apache.spark.unsafe.types.{CalendarInterval,
UTF8String}
object IntervalUtils {
+ object IntervalUnit extends Enumeration {
Review comment:
It's stuff like:
https://groups.google.com/forum/#!topic/scala-internals/8RWkccSRBxQ%5B1-25%5D
But indeed we use scala.Enumeration widely, and I think the issues crop up
when interoperating with Java, or in more obscure cases. I think it's fine here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
