dongjoon-hyun commented on a change in pull request #26225: [SPARK-29568][SS]
Stop existing running streams when a new stream is launched
URL: https://github.com/apache/spark/pull/26225#discussion_r344468705
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
##########
@@ -343,7 +343,10 @@ class StreamingQueryManager private[sql] (sparkSession:
SparkSession) extends Lo
trigger,
triggerClock)
- activeQueriesLock.synchronized {
+ // The following code block checks if a stream with the same name or id is
running. Then it
+ // returns an Option of an already active stream to stop outside of the
lock
+ // to avoid a deadlock.
+ val activeDuplicateQuery = activeQueriesLock.synchronized {
Review comment:
`activeDuplicateQuery` -> `activeDuplicatedQuery`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
