dongjoon-hyun commented on a change in pull request #26430: [SPARK-28859][Core]
Remove value check of MEMORY_OFFHEAP_SIZE
URL: https://github.com/apache/spark/pull/26430#discussion_r344471022
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -254,7 +254,7 @@ package object config {
"consumption must fit within some hard limit then be sure to shrink your
JVM heap size " +
"accordingly. This must be set to a positive value when
spark.memory.offHeap.enabled=true.")
.bytesConf(ByteUnit.BYTE)
- .checkValue(_ >= 0, "The off-heap memory size must not be negative")
+ .checkValue(_ > 0, "The off-heap memory size must be positive.")
Review comment:
Hi, @xingyif . Thank you for making your first PR. BTW, the PR title seems
to be misleading. `Remove value check of MEMORY_OFFHEAP_SIZE` means removing
the whole `.checkValue(_ >= 0)` part. Could you update it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
