dongjoon-hyun commented on a change in pull request #26459: [SPARK-29825][SQL][TESTS] Add join conditions in join-related tests of SQLQueryTestSuite URL: https://github.com/apache/spark/pull/26459#discussion_r344502519
########## File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/join.sql ########## @@ -6,6 +6,11 @@ -- Test JOIN clauses -- https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/join.sql -- + +--SET spark.sql.autoBroadcastJoinThreshold=10485760 Review comment: Also, this looks like a magic number, `10485760`. Could you explain why you choose this value? I don't see this kind of value from the original `https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/join.sql`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
