dongjoon-hyun commented on a change in pull request #26439: [SPARK-29801][ML]
ML models unify toString method
URL: https://github.com/apache/spark/pull/26439#discussion_r344539537
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/clustering/GaussianMixture.scala
##########
@@ -89,6 +89,9 @@ class GaussianMixtureModel private[ml] (
extends Model[GaussianMixtureModel] with GaussianMixtureParams with
MLWritable
with HasTrainingSummary[GaussianMixtureSummary] {
+ @Since("3.0.0")
+ val numFeatures: Int = gaussians.head.mean.size
Review comment:
This PR seems to add at least 4 `numFeatures` instance. Could you add this
into the PR description explicitly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
