HyukjinKwon commented on a change in pull request #26444: [SPARK-29807][SQL]
Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled"
URL: https://github.com/apache/spark/pull/26444#discussion_r344564858
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1655,6 +1655,14 @@ object SQLConf {
.checkValues(Dialect.values.map(_.toString))
.createWithDefault(Dialect.SPARK.toString)
+ val DIALECT_SPARK_ANSI_ENABLED =
buildConf("spark.sql.dialect.spark.ansi.enabled")
Review comment:
I actually think `spark.sql.dialect.spark.ansi.enabled` makes sense because
we can have multiple different directs that can be configured by
`spark.sql.dialect` configuration.
For instance, if we happen to have another configuration specific to
PostgreSQL dialect, we might have to have a configuration as
`spark.sql.dialect.postgresql.blahblah`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
