cloud-fan commented on a change in pull request #26449: [SPARK-29822][SQL] Fix
cast error when there are white spaces between signs and values
URL: https://github.com/apache/spark/pull/26449#discussion_r344566378
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -425,9 +425,12 @@ object IntervalUtils {
}
private object ParseState extends Enumeration {
+ type ParseState = Value
+
val PREFIX,
BEGIN_VALUE,
PARSE_SIGN,
+ TRIM_VALUE,
PARSE_UNIT_VALUE,
FRACTIONAL_PART,
BEGIN_UNIT_NAME,
Review comment:
In `BEGIN_UNIT_NAME` we also trim the spaces. Can we have a consistent way
to do it? Now there are 2 ways:
1. have an intermedia state to trim the spaces
2. trim the spaces at the beginning of a state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
