yaooqinn commented on a change in pull request #26449: [SPARK-29822][SQL] Fix
cast error when there are white spaces between signs and values
URL: https://github.com/apache/spark/pull/26449#discussion_r344578122
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -425,11 +425,15 @@ object IntervalUtils {
}
private object ParseState extends Enumeration {
+ type ParseState = Value
+
val PREFIX,
BEGIN_VALUE,
Review comment:
so we may change `PARSE_UNIT_VALUE` to `PARSE_VALUE` too
How about renaming them all as,
```scala
val PREFIX,
BODY,
SIGN,
TRIM_BEFORE_VALUE,
VALUE,
VALUE_FRACTIONAL_PART,
TRIM_BEFORE_UNIT,
UNIT_BEGIN,
UNIT_SUFFIX,
UNIT_END = Value
```
Seems loud and clear enough for each state
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
