tgravescs commented on a change in pull request #26440:
[WIP][SPARK-20628][CORE] Start to improve Spark decommissioning & preemption
support
URL: https://github.com/apache/spark/pull/26440#discussion_r344751554
##########
File path:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##########
@@ -71,6 +72,9 @@ private[spark] class CoarseGrainedExecutorBackend(
private[executor] val taskResources = new mutable.HashMap[Long, Map[String,
ResourceInformation]]
override def onStart(): Unit = {
+ logInfo("Registering PWR handler.")
+ SignalUtils.register("PWR")(decommissionSelf)
Review comment:
I don't know of any specific issues with having it registered on YARN. I was
just thinking if not needed no reason to register just in case something
unexpected happened. If we don't need the app config for anything else then at
this point I think we can leave it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
