srowen commented on a change in pull request #26462: [SPARK-29833][YARN] Add
FileNotFoundException check for spark.yarn.jars
URL: https://github.com/apache/spark/pull/26462#discussion_r344768389
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
##########
@@ -538,6 +538,9 @@ private[spark] class Client(
if (!Utils.isLocalUri(jar)) {
val path = getQualifiedLocalPath(Utils.resolveURI(jar),
hadoopConf)
val pathFs = FileSystem.get(path.toUri(), hadoopConf)
+ if (!pathFs.exists(path)) {
Review comment:
Wait, no, this check is wrong. That's a glob, not a path.
Maybe check whether the globStatus result is null instead, to narrowly check
what you are trying to?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
