srowen commented on a change in pull request #26454: [SPARK-29818][MLLIB]
Missing persist on RDD
URL: https://github.com/apache/spark/pull/26454#discussion_r344788315
##########
File path: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala
##########
@@ -141,8 +141,10 @@ class CrossValidator @Since("1.2.0") (@Since("1.4.0")
override val uid: String)
Some(Array.fill($(numFolds))(Array.fill[Model[_]](epm.length)(null)))
} else None
+ val inputRDD = dataset.toDF.rdd
+ inputRDD.persist()
Review comment:
This is up to the caller though. At least you'd have to check if it's
already persisted. We add these internal persist calls for important partial
results though, not user inputs, in general, and only if the user input was
cached.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
