dongjoon-hyun commented on a change in pull request #26471: [SPARK-29850][SQL]
sort-merge-join an empty table should not memory leak
URL: https://github.com/apache/spark/pull/26471#discussion_r344912755
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##########
@@ -686,7 +686,7 @@ case class HashAggregateExec(
val thisPlan = ctx.addReferenceObj("plan", this)
// Create a name for the iterator from the fast hash map.
- val iterTermForFastHashMap = if (isFastHashMapEnabled) {
+ val (iterTermForFastHashMap, createFastHashMap) = if
(isFastHashMapEnabled) {
// Generates the fast hash map class and creates the fash hash map term.
Review comment:
nit. typo. `fash hash` -> `fast hash`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
