dongjoon-hyun commented on a change in pull request #26433: [SPARK-29771][K8S] Add configure to limit executor failures URL: https://github.com/apache/spark/pull/26433#discussion_r344931467
########## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala ########## @@ -47,6 +49,16 @@ private[spark] class ExecutorPodsAllocator( private val podCreationTimeout = math.max(podAllocationDelay * 5, 60000) + // maxNumExecutorFailures must be less than Int.MaxValue + private lazy val maxNumExecutorFailures = conf.get(KUBERNETES_MAX_EXECUTOR_FAILURES) Review comment: Is this safe to use `val`? Although this is `lazy val`, the underlying `totalExpectedExecutors` is used in two ways. ``` podAllocator.setTotalExpectedExecutors(initialExecutors) ``` ``` podAllocator.setTotalExpectedExecutors(requestedTotal) ``` This looks a little different from YARN. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
