srowen commented on a change in pull request #26315: [SPARK-29152][CORE]
Executor Plugin shutdown when dynamic allocation is enabled
URL: https://github.com/apache/spark/pull/26315#discussion_r344955850
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -278,35 +282,38 @@ private[spark] class Executor(
}
def stop(): Unit = {
- env.metricsSystem.report()
- try {
- metricsPoller.stop()
- } catch {
- case NonFatal(e) =>
- logWarning("Unable to stop executor metrics poller", e)
- }
- try {
- heartbeater.stop()
- } catch {
- case NonFatal(e) =>
- logWarning("Unable to stop heartbeater", e)
- }
- threadPool.shutdown()
-
- // Notify plugins that executor is shutting down so they can terminate
cleanly
- Utils.withContextClassLoader(replClassLoader) {
- executorPlugins.foreach { plugin =>
- try {
- plugin.shutdown()
- } catch {
- case e: Exception =>
- logWarning("Plugin " + plugin.getClass().getCanonicalName() + "
shutdown failed", e)
+ if (!executorShutdown) {
Review comment:
executorShutdown is volatile; the race is still that it could be set between
this line and the next? yeah agree. While we're here, worth fixing with
AtomicBoolean and compareAndSet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
