rdblue commented on a change in pull request #26425: [SPARK-29789][SQL] should
not parse the bucket column name when creating v2 tables
URL: https://github.com/apache/spark/pull/26425#discussion_r344973767
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/expressions/expressions.scala
##########
@@ -43,20 +43,22 @@ private[sql] object LogicalExpressions {
def reference(name: String): NamedReference =
FieldReference(parser.parseMultipartIdentifier(name))
+ def reference(nameParts: Seq[String]): NamedReference =
FieldReference(nameParts)
Review comment:
It would be good to use a different name to distinguish this from the case
where the reference name is parsed. What about updating the other one to
`parseReference`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
