cloud-fan commented on a change in pull request #26473: [WIP] Strict parsing of
day-time strings to intervals
URL: https://github.com/apache/spark/pull/26473#discussion_r345024238
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/IntervalUtilsSuite.scala
##########
@@ -266,4 +226,59 @@ class IntervalUtilsSuite extends SparkFunSuite {
assert(e.getMessage.contains("divide by zero"))
}
}
+
+ test("from day-time string to interval") {
+ def check(input: String, from: IntervalUnit, to: IntervalUnit, expected:
String): Unit = {
+ withClue(s"from = $from, to = $to") {
+ assert(fromDayTimeString(input, from, to) === fromString(expected))
+ }
+ }
+ def checkFail(
+ input: String,
+ from: IntervalUnit,
+ to: IntervalUnit,
+ errMsg: String): Unit = {
+ try {
+ fromDayTimeString(input, from, to)
+ fail("Expected to throw an exception for the invalid input")
+ } catch {
+ case e: IllegalArgumentException =>
+ assert(e.getMessage.contains(errMsg))
+ }
+ }
+
+ check("12:40", HOUR, MINUTE, "12 hours 40 minutes")
+ check("+12:40", HOUR, MINUTE, "12 hours 40 minutes")
+ check("-12:40", HOUR, MINUTE, "-12 hours -40 minutes")
+ checkFail("5 12:40", HOUR, MINUTE, "must match day-time format")
+
+ check("12:40:30.999999999", HOUR, SECOND, "12 hours 40 minutes 30.999999
seconds")
Review comment:
can we test `12:40:30.0123456789` as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
