cloud-fan commented on a change in pull request #26437: [SPARK-29800][SQL] Plan
non-correlated Exists 's subquery in PlanSubqueries
URL: https://github.com/apache/spark/pull/26437#discussion_r345052326
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
##########
@@ -64,9 +64,9 @@ object SubqueryExpression {
/**
* Returns true when an expression contains an IN or EXISTS subquery and
false otherwise.
*/
- def hasInOrExistsSubquery(e: Expression): Boolean = {
+ def hasInOrCorrelatedExistsSubquery(e: Expression): Boolean = {
e.find {
- case _: ListQuery | _: Exists => true
+ case _: ListQuery | _: Exists if e.children.nonEmpty => true
Review comment:
this will skip non-correlated IN, we should do
```
case _: ListQuery => true
case _: Exists if e.children.nonEmpty => true
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
