cloud-fan commented on a change in pull request #26476: [SPARK-29851][SQL] V2
catalog: Change default behavior of dropping namespace to cascade
URL: https://github.com/apache/spark/pull/26476#discussion_r345058726
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -822,20 +822,44 @@ class DataSourceV2SQLSuite
testShowNamespaces("SHOW NAMESPACES IN testcat", Seq())
}
- test("DropNamespace: drop non-empty namespace") {
+ test("DropNamespace: drop non-empty namespace with a non-cascading mode") {
sql("CREATE TABLE testcat.ns1.table (id bigint) USING foo")
+ sql("CREATE TABLE testcat.ns1.ns2.table (id bigint) USING foo")
testShowNamespaces("SHOW NAMESPACES IN testcat", Seq("ns1"))
+ testShowNamespaces("SHOW NAMESPACES IN testcat.ns1", Seq("ns1.ns2"))
- val e1 = intercept[IllegalStateException] {
- sql("DROP NAMESPACE testcat.ns1")
+ def verifyDropFails(): Unit = {
Review comment:
nit: `assertDropFails`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
