cloud-fan commented on a change in pull request #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception URL: https://github.com/apache/spark/pull/26479#discussion_r345086978
########## File path: sql/core/src/test/resources/sql-tests/inputs/literals.sql ########## @@ -153,3 +153,12 @@ select interval '1' year to second; select '1' year to second; select interval 1 year '2-1' year to month; select 1 year '2-1' year to month; +SET spark.sql.ansi.enabled=false; Review comment: not related to this PR, but it's really annoying to duplicate the test cases with ansi mode on and off. I'm wondering if we can introduce a `-- import abc.sql` directive so that we can easily import test cases in `ansi/interval.sql`, with several ansi specific test cases. cc @maropu ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
