srowen commented on a change in pull request #26386: [SPARK-29476][WEBUI] add
tooltip for Thread
URL: https://github.com/apache/spark/pull/26386#discussion_r345196954
##########
File path:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala
##########
@@ -76,7 +76,12 @@ private[ui] class ExecutorThreadDumpPage(
<div class="bs-example" data-example-id="simple-form-inline">
<div class="form-group">
<div class="input-group">
- Search: <input type="text" class="form-control" id="search"
oninput="onSearchStringChange()"></input>
+ <span data-toggle="tooltip" data-placement="top" title="Searches
(case insensitive) for
Review comment:
Hm, I still think this might be noisy. Too many tooltips will start to
interfere with usability of the screen. I think it's pretty obvious what search
does, so I'm not sure this clarifies much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
