holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE]
Start to improve Spark decommissioning & preemption support
URL: https://github.com/apache/spark/pull/26440#discussion_r345298774
##########
File path:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##########
@@ -71,6 +72,9 @@ private[spark] class CoarseGrainedExecutorBackend(
private[executor] val taskResources = new mutable.HashMap[Long, Map[String,
ResourceInformation]]
override def onStart(): Unit = {
+ logInfo("Registering PWR handler.")
+ SignalUtils.register("PWR")(decommissionSelf)
Review comment:
I think the only situations in which SIGPWR would get sent are from our
script or system shutdown. Now if this a graceful system shutdown which didn't
fall back to an unblockable signal that might be annoying, but I think on
servers it should be fine. But lets leave this comment here incase anyone else
has a counter point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
