turboFei commented on a change in pull request #26482: [SPARK-29857][WEB UI]
Support defer render the spark history summary page.
URL: https://github.com/apache/spark/pull/26482#discussion_r345315755
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala
##########
@@ -68,6 +68,7 @@ private[history] class HistoryPage(parent: HistoryServer)
extends WebUIPage("")
<div id="history-summary" class="row-fluid"></div> ++
<script src={UIUtils.prependBaseUri(request,
"/static/historypage.js")}></script> ++
<script>setAppLimit({parent.maxApplications})</script>
+ <script>setDeferRender({parent.deferRender})</script>
Review comment:
Yeah, that is a good idea.
AFAIK, there is no downside and deferRender is a general optimization.
I will do it tomorrow, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
