vanzin commented on a change in pull request #26390: [SPARK-29399][core] Remove 
old ExecutorPlugin interface.
URL: https://github.com/apache/spark/pull/26390#discussion_r345345164
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkConf.scala
 ##########
 @@ -619,7 +619,9 @@ private[spark] object SparkConf extends Logging {
         "Not used anymore. Please use spark.shuffle.service.index.cache.size"),
 
 Review comment:
   Because the name of the variable hardly matters, what you want is a message 
that explains what's happening with that config (which is what the user sees). 
It was initially created for deprecated configs but works just as well for 
removed ones that we want to warn about.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to