brkyvz commented on a change in pull request #26474: [SPARK-29778] pass writer
options to saveAsTable in append mode
URL: https://github.com/apache/spark/pull/26474#discussion_r345383953
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSuite.scala
##########
@@ -125,4 +128,34 @@ class DataSourceV2DataFrameSuite
checkAnswer(spark.table(t1), Seq(Row("c", "d")))
}
}
+
+ testQuietly("SPARK-29778: saveAsTable: append mode takes write options") {
+
+ var plan: LogicalPlan = null
+ val listener = new QueryExecutionListener {
+ override def onSuccess(funcName: String, qe: QueryExecution, durationNs:
Long): Unit = {
+ plan = qe.analyzed
+ }
+ override def onFailure(funcName: String, qe: QueryExecution, error:
Throwable): Unit = {}
+ }
+ spark.listenerManager.register(listener)
Review comment:
Can we unregister the listener at the end with a `try - finally` please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
