AngersZhuuuu commented on a change in pull request #26437: [SPARK-29800][SQL]
Plan non-correlated Exists 's subquery in PlanSubqueries
URL: https://github.com/apache/spark/pull/26437#discussion_r345537697
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala
##########
@@ -194,6 +258,9 @@ case class PlanSubqueries(sparkSession: SparkSession)
extends Rule[SparkPlan] {
}
val executedPlan = new QueryExecution(sparkSession, query).executedPlan
InSubqueryExec(expr, SubqueryExec(s"subquery#${exprId.id}",
executedPlan), exprId)
+ case expressions.Exists(sub, children, exprId) =>
+ val executedPlan = new QueryExecution(sparkSession, Project(Nil,
sub)).executedPlan
Review comment:
> how about the rule `OptimizeSubqueries`?
correlated and non-correlated subqueries all match here, and we only handle
non-correlated exists. If we add `Project(Nil, ..)` to here need to check
subquery type.
For me, it ok to add it to here since it just handle one case and we can add
comment here to explain why we do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
