xuanyuanking commented on a change in pull request #26444: [SPARK-29807][SQL] 
Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled"
URL: https://github.com/apache/spark/pull/26444#discussion_r345542511
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -1655,6 +1655,20 @@ object SQLConf {
       .checkValues(Dialect.values.map(_.toString))
       .createWithDefault(Dialect.SPARK.toString)
 
+  val ANSI_ENABLED = buildConf("spark.sql.ansi.enabled")
+    .doc("This configuration will be deprecated in the future releases and 
replaced by" +
+      "spark.sql.dialect.ansi.enabled, we keep it now for forward 
compatibility.")
+    .booleanConf
+    .createWithDefault(false)
+
+  val DIALECT_SPARK_ANSI_ENABLED = buildConf("spark.sql.dialect.ansi.enabled")
+    .doc("When true, Spark tries to conform to the ANSI SQL specification: 1. 
Spark will " +
+      "throw a runtime exception if an overflow occurs in any operation on 
integral/decimal " +
+      "field. 2. Spark will forbid using the reserved keywords of ANSI SQL as 
identifiers in " +
+      "the SQL parser.")
+    .booleanConf
+    .createWithDefault(false)
 
 Review comment:
   Thanks for reminding, done in next commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to