cloud-fan commented on a change in pull request #26434: [SPARK-29544] [SQL]
optimize skewed partition based on data size
URL: https://github.com/apache/spark/pull/26434#discussion_r345619968
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ShuffledRowRDD.scala
##########
@@ -116,7 +116,8 @@ class CoalescedPartitioner(val parent: Partitioner, val
partitionStartIndices: A
class ShuffledRowRDD(
var dependency: ShuffleDependency[Int, InternalRow, InternalRow],
metrics: Map[String, SQLMetric],
- specifiedPartitionStartIndices: Option[Array[Int]] = None)
+ specifiedPartitionStartIndices: Option[Array[Int]] = None,
Review comment:
`Option[Array[(Int, Int)]]` is more type-safe. It eliminates problems like
1. `specifiedPartitionStartIndices` is specified but
`specifiedPartitionEndIndices` is not.
2. these 2 have different lengths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
