cloud-fan commented on a change in pull request #26497:
[SPARK-29873][SQL][TESTS] Support `--import` directive to load queries from
another test case in SQLQueryTestSuite
URL: https://github.com/apache/spark/pull/26497#discussion_r345708065
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -325,6 +347,8 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
localSparkSession.conf.set(SQLConf.CROSS_JOINS_ENABLED.key, true)
localSparkSession.conf.set(SQLConf.ANSI_ENABLED.key, true)
Review comment:
We should remove it in the followup, and see if it fails tests. Ideally
pgsql dialect should not be affected by ansi mode config. cc @gengliangwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
