gaborgsomogyi commented on a change in pull request #26416:
[WIP][SPARK-29779][CORE] Compact old event log files and cleanup
URL: https://github.com/apache/spark/pull/26416#discussion_r345739581
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala
##########
@@ -218,12 +219,24 @@ class RollingEventLogFilesFileReader(
private lazy val eventLogFiles: Seq[FileStatus] = {
val eventLogFiles = files.filter(isEventLogFile).sortBy { status =>
- getIndex(status.getPath.getName)
Review comment:
`RollingEventLogFilesWriter` contains now functions for `AppStatusFile`,
`EventLogDir`, `EventLogFile`, `AppStatusFile` and at the end `getIndex` which
only works on event files. I'm not insisting the suggested approach but somehow
it would be good to make order here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
