AngersZhuuuu commented on a change in pull request #26500:
[SPARK-29874][SQL]Optimize Dataset.isEmpty()
URL: https://github.com/apache/spark/pull/26500#discussion_r345775431
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -586,8 +586,8 @@ class Dataset[T] private[sql](
* @group basic
* @since 2.4.0
*/
- def isEmpty: Boolean = withAction("isEmpty",
limit(1).groupBy().count().queryExecution) { plan =>
- plan.executeCollect().head.getLong(0) == 0
+ def isEmpty: Boolean = withAction("isEmpty", queryExecution) { plan =>
Review comment:
> shall we do column pruning?
Of course, add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
