srowen commented on a change in pull request #26138: [SPARK-29456][WebUI]
Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab
URL: https://github.com/apache/spark/pull/26138#discussion_r345776794
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
##########
@@ -445,24 +449,42 @@ private[ui] class SessionStatsPagedTable(
s"&$sessionStatsTableTag.pageSize=$pageSize" +
s"#$sessionStatsTableTag")
val arrow = if (desc) "▾" else "▴" // UP or DOWN
-
- <th width={colWidthAttr}>
- <a href={headerLink}>
- {header} {Unparsed(arrow)}
- </a>
- </th>
+ if (tooltip.nonEmpty) {
+ <th width={colWidthAttr}>
Review comment:
Can we avoid duplicating the th and a elements in both branches?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
