SpaceRangerWes commented on a change in pull request #26474: [SPARK-29778][SQL]
pass writer options to saveAsTable in append mode
URL: https://github.com/apache/spark/pull/26474#discussion_r345918914
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSuite.scala
##########
@@ -125,4 +128,39 @@ class DataSourceV2DataFrameSuite
checkAnswer(spark.table(t1), Seq(Row("c", "d")))
}
}
+
+ testQuietly("SPARK-29778: saveAsTable: append mode takes write options") {
+
+ var plan: LogicalPlan = null
+ val listener = new QueryExecutionListener {
+ override def onSuccess(funcName: String, qe: QueryExecution, durationNs:
Long): Unit = {
+ plan = qe.analyzed
+ }
+ override def onFailure(funcName: String, qe: QueryExecution, error:
Throwable): Unit = {}
+ }
+
+ try {
+ spark.listenerManager.register(listener)
+
+ val t1 = "testcat.ns1.ns2.tbl"
+
+ sql(s"CREATE TABLE $t1 (id bigint, data string) USING foo")
+
+ val df = Seq((1L, "a"), (2L, "b"), (3L, "c")).toDF("id", "data")
+ df.write.option("other", "20").mode("append").saveAsTable(t1)
+
+ sparkContext.listenerBus.waitUntilEmpty()
+ plan match {
+ case p: AppendData =>
+ assert(p.writeOptions == Map("other" -> "20"))
+ case other =>
+ fail(s"Expected to parse ${classOf[AppendData].getName} from query,"
+
Review comment:
@dongjoon-hyun I won't be able to get to this until Thursday evening. I'm
willing to address it, but I didn't know how soon this needed to be merged.
cc: @brkyvz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
