holdenk commented on a change in pull request #26005: [SPARK-29163][SQL] Simplify Hadoop Configuration access in DataSourcev2 URL: https://github.com/apache/spark/pull/26005#discussion_r346051413
########## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/v2/BroadcastedHadoopConf.java ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution.datasources.v2; + + +import org.apache.hadoop.conf.Configuration; + +import org.apache.spark.SparkContext; +import org.apache.spark.annotation.DeveloperApi; +import org.apache.spark.broadcast.Broadcast; +import org.apache.spark.sql.SparkSession; +import org.apache.spark.sql.util.CaseInsensitiveStringMap; +import org.apache.spark.util.SerializableConfiguration; + +import java.util.Map; + +import scala.reflect.ClassTag; +/** + * A helper interface to serialize and broadcast the Hadoop configuration for readers. + */ +@DeveloperApi +public interface BroadcastedHadoopConf { + SparkSession sparkSession(); + CaseInsensitiveStringMap options(); Review comment: To clarify: do you mean you want us to use reflection for something implementing this interface inside of the DSv2 code path? Or do you mean something else? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
