Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/4363#issuecomment-73207417
This is looking close. Had a few more nits and a couple larger comments:
* The documentation needs to be updated. I'm happy to provide wording if
it would be helpful.
* Previously, `toRemove.foreach(removeBlockManager)` would get called to
remove the block manager. Does this happen indirectly now in some way, or do
we need to add this in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
