vanzin commented on a change in pull request #26470: [SPARK-27042][SS]
Invalidate cached Kafka producer in case of task retry
URL: https://github.com/apache/spark/pull/26470#discussion_r346058243
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaProducer.scala
##########
@@ -93,6 +93,10 @@ private[kafka010] object CachedKafkaProducer extends
Logging {
.setAuthenticationConfigIfNeeded()
.build()
val key = toCacheKey(updatedKafkaParams)
+ if (TaskContext.get != null && TaskContext.get.attemptNumber >= 1) {
Review comment:
I know this is just matching what the consumer code does, but I'm a little
unsure that it's correct (in both cases).
Can't you re-use the consumer in different jobs? If so, you can have:
- job 1 task 1 attempt 0 runs with producer 1 and fails
- job 1 task 1 attempt 1 runs with producer 2 and succeeds
- job 2 task 1 attempt 0 runs with producer 1 and re-uses the same instance
that should have been closed?
So I'm wondering if instead the task itself shouldn't be invalidating the
producer when it detects an error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
