rdblue commented on a change in pull request #26214: [SPARK-29558][SQL]
ResolveTables and ResolveRelations should be order-insensitive
URL: https://github.com/apache/spark/pull/26214#discussion_r346064229
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -666,12 +665,26 @@ class Analyzer(
}
/**
- * Resolve table relations with concrete relations from v2 catalog.
+ * Resolve relations to temp views. This is not an actual rule, and is only
called by
+ * [[ResolveTables]].
+ */
+ object ResolveTempViews extends Rule[LogicalPlan] {
Review comment:
I like that this is refactored into a separate rule. Can we move it to an
earlier batch? If metastore views can't contain temp views, then there's no
reason to do this in the same batch as table and view resolution from catalogs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
