HyukjinKwon commented on a change in pull request #26429: [SPARK-29777][SparkR]
SparkR::cleanClosure aggressively removes a function required by user function
URL: https://github.com/apache/spark/pull/26429#discussion_r346098687
##########
File path: R/pkg/R/utils.R
##########
@@ -545,10 +545,6 @@ processClosure <- function(node, oldEnv, defVars,
checkedFuncs, newEnv) {
found <- sapply(funcList, function(func) {
ifelse(identical(func, obj), TRUE, FALSE)
})
- if (sum(found) > 0) {
Review comment:
Is the dead loop case when the same function with the same environments is
recursively called in the closure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
